-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-6211][Streaming] Add Python Kafka API unit test #4961
Conversation
Test build #28427 has started for PR 4961 at commit
|
Test build #28427 has finished for PR 4961 at commit
|
Test FAILed. |
Test build #28429 has started for PR 4961 at commit
|
Test build #28429 has finished for PR 4961 at commit
|
Test FAILed. |
Jenkins, retest this please. |
Test build #28431 has started for PR 4961 at commit
|
Test build #28431 has finished for PR 4961 at commit
|
Test FAILed. |
Test build #28458 has started for PR 4961 at commit
|
Test build #28458 has finished for PR 4961 at commit
|
Test FAILed. |
Looks like maven command in Currently what I did is to use |
This seems like a bug that was fixed couple of weeks ago. Are you sure you have merged with master recently. In fact the PR has merge conflicts. |
|
||
/** | ||
* This is a helper class for Kafka test suites. This has the functionality to set up | ||
* and tear down local Kafka servers, and to push data using Kafka producers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add one line to say why this is in /main and not /test.
Other than the assembly issue, its looks quite good. Only a few minor comments. |
Thanks a lot @tdas for your review, actually I rebased the code in my local environment and tried to test again, seems a recent merged PR #3916 changed the behavior of |
Seems recent merged PR #5261 changed the script and make my test fail, I will fix it. |
Test build #29999 has started for PR 4961 at commit |
Test build #29999 has finished for PR 4961 at commit
|
Test PASSed. |
Jenkins, retest this please. |
Test build #30006 has started for PR 4961 at commit |
Jenkins, retest this please.
|
LGTM. Will merge if it passes. |
Test build #30006 has finished for PR 4961 at commit
|
Test PASSed. |
Merging this. |
Thanks @jerryshao for doing this! |
Refactor the Kafka unit test and add Python API support. CC @tdas @davies please help to review, thanks a lot.